feat(tables): improve view and filter controls by j15z · Pull Request #6725 · simstudioai/sim

j15z · 2026-08-15T02:30:43Z

Summary

This second PR builds on #6724 and completes the table-view control changes. Users can choose which saved view is a table's default via a pin in the Views menu, the Columns menu uses the same menu typography and icon sizing as Sort and stays open across toggles, and the filter builder applies edits as they are made — there are no Apply or Clear buttons. Dropdown and row changes apply immediately; typed text commits on Enter or when focus leaves the field, and every click-driven exit (closing the panel, switching views, navigating away) blurs the field first, so finishing-by-leaving saves the typed value.

Opening the filter panel never writes anything by itself: the save baseline seeds from the builder's own reading of the stored filter, so a stored filter the builder renders differently (deeply nested groups, wire-only operators, key order) is only rewritten once the user actually edits a rule.

Autosave hardening:

An autosave response settling no longer remounts an open filter panel (wiping keystrokes and focus); reapplying a view config with identical content is skipped.
"Filter by cell value" saves the narrowed filter to the view; previously the gesture applied it to the grid without persisting it.
A stale update-view response can no longer demote the current default in the cache; the demotion shares the promoted row's updatedAt staleness guard.
isNull/isNotNull filter conditions round-trip through the builder instead of being dropped on the next save.

Type of Change

Testing

Focused suites for the changed surfaces: 44 tests across the filter panel, views menu, columns menu, sort dropdown, and view-mutation hooks — covering commit-on-Enter/blur, opening a saved filter writing nothing (including OR and isNull shapes), stale promotion responses leaving the default untouched, and the disabled default pin staying inert.
bun run --cwd apps/sim type-check and scoped Biome checks.
Review focus: field-commit semantics, autosave reapply behavior while the panel is open, single-default cache state, and menu selection without closing the menus.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Not included. DOM interaction tests cover the changed menus and filter-commit behavior.

Post-Deploy Monitoring & Validation

For 24 hours, monitor table-view update errors and save-error toasts after filter, column, and default-view interactions.
Validate that selecting "Set as default" leaves exactly one default view and that the chosen view opens after returning to the table.
Validate that typed filters apply on Enter or when focus leaves the field, persist after closing the panel or navigating away, and that opening a saved view's filter panel writes nothing on its own.
Treat increased table-view update failures, duplicate defaults, or lost filter state as rollback triggers.
Owner: Tables feature maintainers. This child PR can be rolled back independently if the new controls regress while the autosave foundation remains healthy.

vercel · 2026-08-15T02:30:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 17, 2026 7:14pm

cursor · 2026-08-15T02:30:54Z

PR Summary

Medium Risk
Changes touch live filter persistence, view default promotion, and filter round-trip edge cases—user-visible data and view state can regress if signature or cache logic is wrong, but scope is limited to table UI and view mutations.

Overview
Table view controls get pin-as-default in the views menu (filled/outline pin icons, menu stays open), Columns switched from popover to dropdown with Sort-aligned styling, and Sort dropdown items that no longer close on clear or direction change.

Filters move from Apply/Clear to onChange autosave: value fields buffer locally and commit on Enter/blur; rule changes apply via a signature guard so opening the panel does not rewrite saved OR/isNull trees until the user edits. Apply/Clear UI is removed; removing the last rule clears the filter immediately.

Table page wires filter persistence to the active view, skips replaceFilter when the incoming predicate matches the current one (avoids remount/focus loss on autosave echo), and explicitly persists filter by cell value. View mutation cache optimistically demotes the previous default and ignores stale promotion responses that would leave no default.

Tests cover the new filter, columns, views, sort, and hook behaviors.

^{Reviewed by Cursor Bugbot for commit e4f0403. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-08-15T02:35:18Z

Greptile Summary

The PR streamlines table view, column, and filter controls, adding a set-default action and debounced filter updates.

Migrates the columns picker to the standard dropdown menu.
Adds optimistic default-view reconciliation.
Replaces explicit filter application and OR controls with automatic AND-only filtering.

Confidence Score: 4/5

The PR should not merge until opening an existing OR filter stops silently rewriting and persisting it as AND.

The new filter initialization changes supported saved predicate semantics, and the automatic debounce persists that change without user interaction.

Files Needing Attention: apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-filter/table-filter.tsx, apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-filter/table-filter.tsx	Adds debounced automatic filtering but silently rewrites loaded OR predicates to AND and triggers persistence on mount.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx	Integrates filter flushing, set-default actions, and view persistence; its generic filter persistence makes the mount-time normalization destructive.
apps/sim/hooks/queries/tables.ts	Optimistically demotes the previous default when a promoted view response arrives, followed by authoritative invalidation.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/columns-menu/columns-menu.tsx	Migrates column visibility controls to the standard dropdown while retaining the existing toggle behavior.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.tsx	Adds an edit-gated set-default action for non-default views.

Sequence Diagram

sequenceDiagram
  participant User
  participant Filter as TableFilter
  participant Table
  participant View as Saved view
  User->>Filter: Open saved OR filter
  Filter->>Filter: Convert every rule to AND
  Filter->>Filter: Debounce 250 ms
  Filter->>Table: onChange(AND predicate)
  Table->>View: Persist filter config

_{Reviews (1): Last reviewed commit: "feat(tables): improve view and filter co..." | Re-trigger Greptile}

greptile-apps · 2026-08-15T02:35:21Z

+    const fromFilter = predicateToFilterRules(filter).map((rule) => ({
+      ...rule,
+      logicalOperator: 'and' as const,
+    }))


OR filters are silently overwritten

When a saved view contains an any predicate, initialization changes every rule boundary to and, and the mount effect then sends that changed predicate through onChange, causing the displayed rows and persisted view to switch from OR to AND without a user edit.

Knowledge Base Used: User Tables (apps/sim/lib/table)

…onses Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 0d65580. Configure here.}

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat(tables): improve view and filter controls

9fb56ae

vercel Bot temporarily deployed to Preview August 15, 2026 02:30 Inactive

j15z mentioned this pull request Aug 15, 2026

feat(tables): autosave persisted default views #6724

Open

10 tasks

cursor Bot reviewed Aug 15, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx Outdated

greptile-apps Bot reviewed Aug 15, 2026

View reviewed changes

fix(tables): keep menu actions open

5a1ffbd

vercel Bot temporarily deployed to Preview August 15, 2026 02:59 Inactive

cursor Bot reviewed Aug 15, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.tsx

j15z and others added 3 commits August 15, 2026 19:47

fix(tables): guard view autosave against echo remounts and stale resp…

e080527

…onses Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix(tables): keep and/or filter toggles, autosave only real edits

de5766c

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix(tables): compute view-row action spacer and cover the default pin

0d65580

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vercel Bot temporarily deployed to Preview August 16, 2026 02:48 Inactive

cursor Bot reviewed Aug 16, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

feat(tables): apply filter text on enter or blur instead of a debounce

e4f0403

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vercel Bot temporarily deployed to Preview August 17, 2026 19:14 Inactive

Navigation Menu

Uh oh!

feat(tables): improve view and filter controls - #6725

feat(tables): improve view and filter controls#6725
j15z wants to merge 6 commits into
feat/better-table-views-uxfrom
feat/table-view-controls

j15z commented Aug 15, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Aug 15, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Aug 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 15, 2026

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Aug 15, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

j15z commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Screenshots/Videos

Post-Deploy Monitoring & Validation

Uh oh!

vercel Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Aug 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 15, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps Bot Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

j15z commented Aug 15, 2026 •

edited

Loading

vercel Bot commented Aug 15, 2026 •

edited

Loading

cursor Bot commented Aug 15, 2026 •

edited

Loading