fix: 'no entry found for key' panic in VFS - #23120
Merged
ChayimFriedman2 merged 1 commit intoAug 11, 2026
Merged
Conversation
The doc comment of `resolve_path()` claims that it returns None if the path's anchor isn't present, but it actually panics due to `[]` indexing. Return None instead, matching the documented behaviour. I've seen this crash impact a handful of users, but I haven't been able to replicate it myself. It seems to occur when files are deleted, probably when switching branches. It also seems to recover when the crate graph is rebuilt. The fix seems obviously correct though, so I've just changed the code without a regression test. AI disclosure: Some Opus 5 usage for the code changes.
ChayimFriedman2
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc comment of
resolve_path()claims that it returns None if the path's anchor isn't present, but it actually panics due to[]indexing.Return None instead, matching the documented behaviour.
I've seen this crash impact a handful of users, but I haven't been able to replicate it myself. It seems to occur when files are deleted, probably when switching branches. It also seems to recover when the crate graph is rebuilt.
The fix seems obviously correct though, so I've just changed the code without a regression test.
AI disclosure: Some Opus 5 usage for the code changes.