fix: don't offer replace_qualified_name_with_use on an unqualified path - #22919
Merged
Conversation
ChayimFriedman2
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22691
When a crate and an item inside it share a name,
sub()resolves to the crate in the type namespace, so the assist is offered on a path that has no qualifier at all. It then imports the crate itself (use sub;) and leaves the call untouched, which is a no-op edit on code that does not compile either way. There is nothing to replace here, so the assist should not be offered.🤖 AI-assisted: understanding the issue, locating the cause, and writing the test.