[3.15] gh-153005: Use a monotonic clock for concurrent.interpreters Queue timeouts (GH-154156) - #155967
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-153005: Use a monotonic clock for concurrent.interpreters Queue timeouts (GH-154156)#155967miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…eue timeouts (pythonGH-154156) Queue.get() and Queue.put() computed their timeout deadline from time.time(), the wall clock. If the system clock was stepped (NTP, a manual change) while a call was blocked, the timeout could over- or under-wait. queue.Queue uses time.monotonic() for the same reason. Compute the deadline and check it against time.monotonic() instead. (cherry picked from commit b94b9c8886a987a324a677b5fda5bef27f15cb14) Co-authored-by: Vyron Vasileiadis <hi@fedonman.com>
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue.get() and Queue.put() computed their timeout deadline from
time.time(), the wall clock. If the system clock was stepped (NTP, a
manual change) while a call was blocked, the timeout could over- or
under-wait. queue.Queue uses time.monotonic() for the same reason.
Compute the deadline and check it against time.monotonic() instead.
(cherry picked from commit b94b9c8)
Co-authored-by: Vyron Vasileiadis hi@fedonman.com