Skip to content

bpo-31904: fix test_utf8_mode fail issue on VxWorks #12428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Mar 27, 2019
Merged

bpo-31904: fix test_utf8_mode fail issue on VxWorks #12428

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fedc23
bpo-31904: fix test_utf8_mode fail issue on VxWorks
hliu0 Mar 19, 2019
0ecfe87
bpo-31904: add missing rst files
hliu0 Mar 19, 2019
df7d5d4
bpo-31904: fix test_utf8_mode fail issue on VxWorks
hliu0 Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-31904: add missing rst files
  • Loading branch information
@hliu0
hliu0 committed Mar 19, 2019
commit 0ecfe87ff95d3511eebcd51cd2556e6a03bfbfd4
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2019-03-19-17-39-25.bpo-31904.QxhhRx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
VxWorks uses UTF-8 as the system encoding. So the test case test_utf8_mode.py
need to be updated to use UTF-8 on VxWorks.

@vstinner vstinner Mar 26, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose:

Fix test_utf8_mode on VxWorks: Python always use UTF-8 on VxWorks .

@hliu0 hliu0 Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes; please review again