Don't modify LS settings if jediEnabled does not exist - #12551
Merged
Jake Bailey (jakebailey) merged 2 commits intoJun 24, 2020
Conversation
Jake Bailey (jakebailey)
requested review from
Mikhail Arkhipov (MikhailArkhipov) and
Karthik Nadig (karthiknadig)
June 24, 2020 22:18
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM. Over to owners to approve. |
Karthik Nadig (karthiknadig)
approved these changes
Jun 24, 2020
Karthik Nadig (karthiknadig)
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Jun 24, 2020
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
Jun 25, 2020
* Fix `linting.pylintEnabled` setting check (#12444) * Fix `linting.pylintEnabled` setting check * Use stub instead of handspun variable * Don't modify LS settings if jediEnabled does not exist (#12551) * Update change logs and version Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #12429
Not sure if I can add a news for this, given it's a bugfix for a bugfix...
Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.