Fix functional tests for ipywidgets and download just chrome browser - #11093
Merged
Don Jayamanne (DonJayamanne) merged 1 commit intoApr 11, 2020
Merged
Conversation
Don Jayamanne (DonJayamanne)
requested review from
David Kutugata (DavidKutu),
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
April 10, 2020 23:06
|
Kudos, SonarCloud Quality Gate passed!
|
Ian Huff (IanMatthewHuff)
approved these changes
Apr 10, 2020
Member
|
Nice, I think the browser download was slowing down npm ci a bunch. noticed it after merging master into ds/rawKernel. |
Rich Chiodo (rchiodo)
approved these changes
Apr 10, 2020
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Apr 13, 2020
For #11092 playwright downloads other browsers, we need just one chrome (as this is closest to what VSCode is built upon)
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Apr 14, 2020
* Load widget scripts from CDN and/or local python interpreter (#10987) * Address sonar issues * Fix linter * Fixes * Better way to pas array buffer * Added comments * Oops * Copy widget scripts to extension folder (#11082) * Copy widget scripts to extension folder * Fix test * Remove aml scripts from extension (#11085) * Validate python when nb opened not on extension activates (#11087) For #10893 * Support workspace images in markdown cells (#11086) For #10893 * Fix functional tests for ipywidgets and download just chrome b… (#11093) For #11092 playwright downloads other browsers, we need just one chrome (as this is closest to what VSCode is built upon) * Added tests for k3d widget (#11133) For #10799, #11096 * Fix failing ipywidget tests (#11132) For #11099 * Update change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #11092
playwrightdownloads other browsers, we need just onechrome(as this is closest to what VSCode is built upon)