Fix problem with undoing entire stack - #10018
Merged
Merged
Conversation
Rich Chiodo (rchiodo)
requested review from
David Kutugata (DavidKutu),
Don Jayamanne (DonJayamanne) and
Ian Huff (IanMatthewHuff)
February 10, 2020 17:11
|
Kudos, SonarCloud Quality Gate passed!
|
Ian Huff (IanMatthewHuff)
approved these changes
Feb 10, 2020
Codecov Report
@@ Coverage Diff @@
## ds/custom_editor #10018 +/- ##
===================================================
Coverage ? 60.8%
===================================================
Files ? 564
Lines ? 29882
Branches ? 4491
===================================================
Hits ? 18171
Misses ? 10718
Partials ? 993
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you save a file, then undo back to when the undo stack is empty, the file should be dirty.
VS code will show the dirty icon on the file, but we won't enable the save button on the UI.