Run discovery on CI and adjust Conda env discovery - #9
Merged
Conversation
Don Jayamanne (DonJayamanne)
force-pushed
the
ciTests
branch
from
June 5, 2024 04:24
9a7697c to
840bd06
Compare
| programdata: env.get_env_var("PROGRAMDATA".to_string()), | ||
| homedrive: env.get_env_var("HOMEDRIVE".to_string()), | ||
| conda_root: env.get_env_var("ALLUSERSPROFILE".to_string()), | ||
| conda_root: env.get_env_var("CONDA_ROOT".to_string()), |
Collaborator
Author
There was a problem hiding this comment.
First bug from real python on CI
Thanks for setting up Python Karthik Nadig (@karthiknadig)
| shell: bash | ||
|
|
||
| - name: Find Environments | ||
| run: cargo run --release --target ${{ matrix.target }} |
Collaborator
Author
There was a problem hiding this comment.
This is harmless, given this runs in < 100ms
I want this running everytime so we can see the results.
Don Jayamanne (DonJayamanne)
marked this pull request as ready for review
June 5, 2024 05:31
Don Jayamanne (DonJayamanne)
enabled auto-merge (squash)
June 5, 2024 05:31
Sandeep Somavarapu (sandy081)
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.