add set log level handler for setting log level from vscode side. - #47
Merged
Conversation
|
Andy Xu(devdiv) (@andxu), |
Jinbo Wang (testforstephen)
previously approved these changes
Sep 25, 2017
Rome Li (akaroml)
requested changes
Sep 25, 2017
| if (arguments != null && arguments.size() == 1 && arguments.get(0) instanceof String) { | ||
| try { | ||
| logger.setLevel(Level.parse((String) arguments.get(0))); | ||
| logger.warning(String.format("Set log level to : %s", arguments.get(0))); |
Member
There was a problem hiding this comment.
why is this a warning?
info is enough to tell the user the log level is set to whatever they specified.
| logger.warning(String.format("Set log level to : %s", arguments.get(0))); | ||
| return logger.getLevel().toString(); | ||
| } catch (IllegalArgumentException e) { | ||
| logger.warning(String.format("Invalid log level: %s", arguments.get(0))); |
Member
There was a problem hiding this comment.
It should be an error.
| } | ||
|
|
||
| } else { | ||
| logger.warning(String.format("Invalid parameters for configLogLevel: %s", StringUtils.join(arguments))); |
Member
There was a problem hiding this comment.
It should be an error.
Rome Li (akaroml)
approved these changes
Sep 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.