Preserve explicitly set figure DPI when pickling - #32233
Conversation
|
Thank you for opening your first PR into Matplotlib! If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks. We also ask that you please finish addressing any review comments on this PR and wait for it to be merged (or closed) before opening a new one, as it can be a valuable learning experience to go through the review process. You can also join us on discourse chat for real-time discussion. For details on testing, writing docs, and our review process, please see the developer guide. We strive to be a welcoming and open project. Please follow our Code of Conduct. |
PR summary
Closes #32053
This commit makes set_dpi() update _original_dpi first, then calculates the effective DPI as:
requested DPI × device-pixel ratioThat preserves the user’s DPI choice through pickle round-trips, still behaves correctly on HiDPI displays, and makes savefig(dpi="figure") use the explicitly set DPI.
It also routes SubFigure.set_dpi() through the parent figure’s public setter, so SubFigures follow the same behavior.
Tested normal and HiDPI cases.
AI Disclosure
AI was used for making the change and testing it locally.
PR quality check