Implement Figure-level overlay architecture with two-pass drawing - #32199
Open
Vikash-Kumar-23 wants to merge 4 commits into
Open
Implement Figure-level overlay architecture with two-pass drawing#32199Vikash-Kumar-23 wants to merge 4 commits into
Vikash-Kumar-23 wants to merge 4 commits into
Conversation
Vikash-Kumar-23
force-pushed
the
container-managed-overlays
branch
from
August 13, 2026 07:25
5da353c to
3dcb434
Compare
story645
reviewed
Aug 13, 2026
| fig._draw_base_layer = lambda renderer: None | ||
| fig.patch.set_alpha(0.0) | ||
| ax.patch.set_alpha(0.0) | ||
|
|
Member
There was a problem hiding this comment.
I think you need three tests here:
- base
- overlay
- composite
b/c if you have to knock out the patch on the overlay, that seems to indicate you're not getting clean independence.
ksunden
reviewed
Aug 13, 2026
ksunden
left a comment
Member
There was a problem hiding this comment.
The main idea for this review is to push towards making the layering system more generic. Instead of just one overlay, it is possible to extend into more, which has the added benefit of enabling us to clean up the code and reduce duplicated code.
I've laid out a series of specific changes that I think will add up to making this more useful and cleaner, outlined below.
Vikash-Kumar-23
force-pushed
the
container-managed-overlays
branch
from
August 16, 2026 07:29
3dcb434 to
e31aff1
Compare
Vikash-Kumar-23
force-pushed
the
container-managed-overlays
branch
from
August 16, 2026 07:48
e31aff1 to
d78afb3
Compare
Contributor
Author
|
@ksunden @story645 Thanks for the feedback! I've updated the architecture based on your suggestion to make Here are the updates pushed in the latest commit:
|
story645
reviewed
Aug 18, 2026
ksunden
reviewed
Aug 19, 2026
story645
reviewed
Aug 21, 2026
Comment on lines
+1128
to
+1131
| self._children_by_layer = { | ||
| "patch": [self.patch], | ||
| "base": self._children, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR introduces a foundational Figure-level overlay architecture to
figure.py. It implements a two-pass drawing system, allowing developers to cleanly segregate base plot artists from overlay artists.Key Changes:
_children_by_layerdictionary inFigureBase. Artists are now routed to distinct lists based on their layer (e.g.,"base","overlay"), andself.patchhas been isolated into its own dedicated"patch"layer.Figure.draw()andSubFigure.draw()to execute in multiple passes using a new, generic_draw_layer(renderer, layer_name)method. The strict sequence is now:"patch"layer: Renders the figure background first."base"layer: Renders all standard artists."overlay"layer: Renders all overlay artists last.layer=Nonekeyword-only argumentadd_artistandget_childrenAddresses #30515
AI Disclosure
AI tools were used to assist in drafting text and suggesting validation scenarios.
All code changes, final implementation decisions, and verification were done manually.
PR quality check