TST: Increase some tolerances for non-x86_64 architectures - #31946
Merged
Conversation
All of these were tightened in matplotlib#31303, but it appears necessary to increase these ones for at least aarch64, ppc64le, and s390x, so switch the condition to the architecture. Note that our CI runs macOS on ARM, so the conditions for those should be fine to switch to architectures, since they aren't x86_64.
5 tasks
Member
Author
|
I've confirmed that this fixes the build on the other architectures with a scratch build. |
tacaswell
approved these changes
Jun 26, 2026
timhoffm
approved these changes
Jun 26, 2026
QuLogic
pushed a commit
that referenced
this pull request
Jun 27, 2026
QuLogic
added a commit
that referenced
this pull request
Jun 27, 2026
…946-on-v3.11.x Backport PR #31946 on branch v3.11.x (TST: Increase some tolerances for non-x86_64 architectures)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
All of these were tightened in #31303, but it appears necessary to increase these ones for at least aarch64, ppc64le, and s390x, so switch the condition to the architecture. Note that our CI runs macOS on ARM, so the conditions for those should be fine to switch to architectures, since they aren't x86_64.
AI Disclosure
None
PR checklist