REORG: add a LineStyle class - #18664
Closed
brunobeltran wants to merge 3 commits into
Closed
Conversation
brunobeltran
force-pushed
the
line_style
branch
from
October 6, 2020 19:20
b08a67f to
6197d1f
Compare
brunobeltran
force-pushed
the
line_style
branch
2 times, most recently
from
December 14, 2020 21:49
7b454c2 to
843e517
Compare
brunobeltran
force-pushed
the
line_style
branch
from
January 4, 2021 20:04
843e517 to
e23afa2
Compare
brunobeltran
force-pushed
the
line_style
branch
from
January 4, 2021 21:48
e23afa2 to
fc631b7
Compare
brunobeltran
force-pushed
the
line_style
branch
from
February 1, 2021 18:24
fc631b7 to
5b694af
Compare
brunobeltran
force-pushed
the
line_style
branch
from
February 1, 2021 20:02
5b694af to
451ca5a
Compare
|
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
5 tasks
Member
|
I don't think we'll go further in the direction of full type classes. See also the discussion in #14642. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
WIP. Goes on top of #18544.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).