Skip to content

#3524 provide tests with delomboked classes annotated with lomboks @SuperBuilder annotation - #3542

Merged
filiphr merged 2 commits into
mainfrom
5324
Mar 10, 2024
Merged

#3524 provide tests with delomboked classes annotated with lomboks @SuperBuilder annotation#3542
filiphr merged 2 commits into
mainfrom
5324

Conversation

@thunderhook

@thunderhook thunderhook commented Mar 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Haven't found that many different scenarios. I hope it's enough to show that it works.

If you have any further wishes or suggestions, please let me know.

Closes #3524

@thunderhook
thunderhook requested a review from filiphr March 1, 2024 23:04
filiphr
filiphr requested changes Mar 3, 2024
View reviewed changes

@filiphr filiphr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thunderhook, this looks OK to me. I have only one small request. Let's remove Lombok from the package the javadoc. This is about a super builder, so let's only keep that in the naming. Let's also remove the things that are not needed for the tests like the equals and hashCode methods.

Comment thread processor/src/test/java/org/mapstruct/ap/test/lombok/package-info.java Outdated

@filiphr filiphr Mar 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a package-info.java for this?

@thunderhook

thunderhook commented Mar 3, 2024

Copy link
Copy Markdown
Contributor Author

@filiphr Thanks for the suggestions. I tried to keep it as "original" as possible, hence the equals/hashCode, but no problem. I will remove it.

The package-info.java was was an attempt to show that other (de)lombok(ed) tests can also be added there.

So just name the package `org.mapstruct.ap.test.superbuilder' and remove any trace of Lombok?

@filiphr

filiphr commented Mar 3, 2024

Copy link
Copy Markdown
Member

So just name the package `org.mapstruct.ap.test.superbuilder' and remove any trace of Lombok?

Indeed, rename the package and remove the Lombok traces. Try to limit it to the minimum that we need to test super builders. Thanks

@filiphr
filiphr merged commit e815e3c into main Mar 10, 2024
@filiphr

filiphr commented Mar 10, 2024

Copy link
Copy Markdown
Member

Thanks @thunderhook

@filiphr
filiphr deleted the 5324 branch March 10, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr filiphr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve tests to show that Lombok @SuperBuilder is supported

2 participants

@thunderhook @filiphr