Fix validation issue of lastModifier for configuration and routes - #6072
Conversation
knative-prow-robot
left a comment
There was a problem hiding this comment.
@savitaashture: 0 warnings.
Details
In response to this:
Fixes #5964
Proposed Changes
- add changes to configuration and routes to validate serving.knative.dev/creator and serving.knative.dev/lastModifier when ownerReference is nil
Release Note
None
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
vagababov
left a comment
There was a problem hiding this comment.
Please add unit tests.
| original := apis.GetBaseline(ctx).(*Configuration) | ||
| errs = errs.Also(apis.ValidateCreatorAndModifier(original.Spec, c.Spec, original.GetAnnotations(), | ||
| c.GetAnnotations(), serving.GroupName).ViaField("metadata.annotations")) | ||
| if c.OwnerReferences == nil { |
There was a problem hiding this comment.
I think all those deserve a comment
f70e5a9 to
e28ec3c
Compare
e28ec3c to
5be0a45
Compare
|
@vagababov |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, savitaashture, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5964
Proposed Changes
Release Note