Skip to content

Fix failing tests for cohere_compass - #48005

Open
kaixuanliu wants to merge 3 commits into
huggingface:mainfrom
kaixuanliu:fix-model-tests-cohere_compass-20260817
Open

Fix failing tests for cohere_compass#48005
kaixuanliu wants to merge 3 commits into
huggingface:mainfrom
kaixuanliu:fix-model-tests-cohere_compass-20260817

Conversation

@kaixuanliu

@kaixuanliu kaixuanliu commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix 10 failed cases for cohere_compass model tests:

FAILED tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_model_parallelism - AttributeError: 'CohereCompassModel' object has no attribute 'hf_device_map'
FAILED tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_model_parallel_beam_search - RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:3 and cuda:1!
SUBFAILED[CohereCompassModel/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_dynamic - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)
SUBFAILED[CohereCompassForConditionalGeneration/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_dynamic - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)
SUBFAILED[CohereCompassForConditionalGeneration/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_dynamic - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)
SUBFAILED[CohereCompassForConditionalGeneration/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_dynamic_static_cache - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)
SUBFAILED[CohereCompassForConditionalGeneration/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_static - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)
SUBFAILED[CohereCompassForConditionalGeneration/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_static_static_cache - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)
SUBFAILED[CohereCompassModel/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_static - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)
SUBFAILED[CohereCompassForConditionalGeneration/image_encoder] tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_static - torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression u0 > 1 (unhinted: u0 > 1).  (Size-like symbols: none)

@kaixuanliu
fix(cohere_compass): address failing tests
c203b83 
Fixed 8 test(s):
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_model_parallel_beam_search
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_model_parallelism
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_dynamic
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_dynamic
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_dynamic_static_cache
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_static
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_generate_static_static_cache
- tests/models/cohere_compass/test_modeling_cohere_compass.py::CohereCompassModelTest::test_torch_export_static
@kaixuanliu
update
87bab1a 
Signed-off-by: kaixuanliu <kaixuan.liu@intel.com>
@kaixuanliu
update
a3f848a 
Signed-off-by: kaixuanliu <kaixuan.liu@intel.com>
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: cohere_compass

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 32003398477:2
Result: success | Jobs: 8 | Tests: 694 | Failures: 0 | Duration: 5m 15s

@kaixuanliu
kaixuanliu marked this pull request as ready for review August 17, 2026 07:44
@kaixuanliu

kaixuanliu commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@ydshieh pls help review, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rocketknight1 Rocketknight1 Awaiting requested review from Rocketknight1
@ydshieh ydshieh Awaiting requested review from ydshieh

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kaixuanliu