Skip to content

Spec changes for atomic vec2u - #5610

Open
petermcneeleychromium wants to merge 15 commits into
gpuweb:mainfrom
petermcneeleychromium:spec_changes_for_atomic_vec2u
Open

Spec changes for atomic vec2u#5610
petermcneeleychromium wants to merge 15 commits into
gpuweb:mainfrom
petermcneeleychromium:spec_changes_for_atomic_vec2u

Conversation

@petermcneeleychromium

Copy link
Copy Markdown
Contributor

Original approved proposal
https://github.com/gpuweb/gpuweb/blob/main/proposals/atomic-64-min-max.md

This feature is extremely limited to side effect/mutation in storage buffers.
There is no return value so no way of creating synchronize-with sequencing.

@alan-baker alan-baker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the fence about using vec2u in the core spec text. I think we generally expand it out to vec2<u32> (though it is likely used in examples).

Comment thread spec/index.bs Outdated
Comment thread wgsl/index.bs
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
@petermcneeleychromium

Copy link
Copy Markdown
Contributor Author

On the fence about using vec2u in the core spec text. I think we generally expand it out to vec2<u32> (though it is likely used in examples).

I use it as the name of the enable !

@alan-baker

Copy link
Copy Markdown
Contributor

On the fence about using vec2u in the core spec text. I think we generally expand it out to vec2<u32> (though it is likely used in examples).

I use it as the name of the enable !

I think it's ok there. More in the type definition is where I'm less sure.

@github-actions

github-actions Bot commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (19bad54):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@alan-baker alan-baker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits mostly.

Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this ought to change. No certain how though.

Comment thread wgsl/index.bs Outdated

@dneto0 dneto0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My complaints are editorial.

Also, why are there new summaries of WGSL in this patch? Please remove thema.

I have a good idea of what I would write instead; I'll try to coordinate with @petermcneeleychromium to see who should make them.

Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl_summary.md Outdated
Comment thread wgsl_expanded_summary.md Outdated
@dneto0
dneto0 force-pushed the spec_changes_for_atomic_vec2u branch from 5a69c30 to b0870fb Compare July 13, 2026 20:30
@dneto0
dneto0 force-pushed the spec_changes_for_atomic_vec2u branch from b0870fb to d561e5b Compare July 13, 2026 20:33

@dneto0 dneto0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now works for me.

@dneto0
dneto0 requested a review from alan-baker July 13, 2026 20:34
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
Comment thread wgsl/index.bs Outdated
dneto0 and others added 4 commits July 14, 2026 10:25
Co-authored-by: alan-baker <alanbaker@google.com>
Co-authored-by: alan-baker <alanbaker@google.com>
Co-authored-by: alan-baker <alanbaker@google.com>
Co-authored-by: alan-baker <alanbaker@google.com>
@dneto0
dneto0 requested a review from alan-baker July 14, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants