feat(firestore): support vector query in transactions - #14460
Merged
Conversation
bhshkh
enabled auto-merge (squash)
April 20, 2026 19:37
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a query() method to the VectorQuery struct and adds a new test case, TestRunTransaction_VectorQuery, to verify vector query functionality within transactions. Feedback suggests using a pointer receiver for the query() method to avoid unnecessary copying of the underlying Query struct and to prevent heap escape.
hongalex
reviewed
Apr 20, 2026
hongalex
approved these changes
Apr 21, 2026
This was referenced Jun 16, 2026
Closed
shollyman
pushed a commit
that referenced
this pull request
Jul 9, 2026
🤖 I have created a release *beep* *boop* --- ## [1.23.0](firestore/v1.22.0...firestore/v1.23.0) (2026-07-09) ### Features * **firestore:** Add Data and DataTo methods to AggregationResult ([#14592](#14592)) ([66c66c5](66c66c5)), closes [#13646](#13646) * **firestore:** Add limit, offset, and languageCode options ([#20029](#20029)) ([bfbbee6](bfbbee6)) * **firestore:** Configure client to support 16MB documents ([#14684](#14684)) ([1a52421](1a52421)) * **firestore:** Support BSON types ([#14622](#14622)) ([fac54ad](fac54ad)) * **firestore:** Support Transaction ReadTime ([#14615](#14615)) ([b54d7a4](b54d7a4)) * **firestore:** Support vector query in transactions ([#14460](#14460)) ([4b8c904](4b8c904)) * Update API sources and regenerate ([#19950](#19950)) ([c7607be](c7607be)) ### Bug Fixes * **firestore:** Bubble up errors in BulkWriter ([#14481](#14481)) ([3553da6](3553da6)) * **firestore:** Enforce backpressure in BulkWriter ([#12938](#12938)) ([820d0a2](820d0a2)), closes [#11422](#11422) * **firestore:** More precision fixes ([#20073](#20073)) ([7843ebf](7843ebf)) * **firestore:** Retry transient connection errors during document reads ([#20057](#20057)) ([875f97e](875f97e)), closes [#10350](#10350) * **firestore:** Robust transaction rollback on cancellation ([#14687](#14687)) ([7c5b013](7c5b013)) * **firestore:** Use higher precision for read times ([#20068](#20068)) ([61471b8](61471b8)) * **firestore:** Use passthrough scheme for emulator connections ([#14616](#14616)) ([f8eb671](f8eb671)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12837