Add predicted kij from Hemprich et al - #379
Draft
prehner wants to merge 1 commit into
Draft
Conversation
prehner
force-pushed
the
hemprich_parameters
branch
from
August 11, 2026 14:50
3521c06 to
2dc3116
Compare
prehner
force-pushed
the
hemprich_parameters
branch
from
August 12, 2026 12:31
2dc3116 to
ea33e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Add link to published paper when available.
The database is 77 MB, should we have such a large file in the repo or find another way to distribute it?
Edit: There are other ways to make large parameter files available. So the plan for now is to not upload it to this repo and this PR mainly serves as a remainder to update the README of the PCP-SAFT parameters once the paper is published