docs(authentication): clarify OAuth authStrategies security - #3698
Merged
Conversation
Document that OAuth providers belong under authentication.oauth and must not be listed in public authStrategies for browser redirect SSO. Rewrite flow #2 guidance so provider-token login requires a verifying getProfile, and cross-link guides and cookbooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents a common OAuth misconfiguration: listing provider names (
google,microsoft, etc.) in publicauthentication.authStrategieswhen only the browser redirect flow is needed.authentication.oauth; omit providers fromauthStrategies(matches the generator).authStrategiesallows strategies on externalPOST /authentication. DefaultgetProfilereturnsdata.profileand does not verify a provider token, so a client-suppliedprofile/submust never be treated as identity.getProfile(Facebook Graph / FirebaseverifyIdTokenpatterns).Changes
docs/api/authentication/oauth.mdgetProfile/getEntityDatanotesdocs/api/authentication/service.mdauthStrategiesvs OAuth configdocs/guides/security.mddocs/guides/basics/login.mdauthStrategiesdocs/guides/cli/authentication.mddocs/guides/cli/default.json.mddocs/cookbook/authentication/google.mdauthStrategiesdocs/cookbook/authentication/facebook.mdgetProfilerequired if inauthStrategiesdocs/cookbook/authentication/firebase.mdauthStrategies+ why verification makes it safeOut of scope
Runtime hardening of
OAuthStrategy(reject bare client profile, emptysub, identity-lookup query isolation) is intentionally separate from this docs pass.Test plan
#configuration-and-security,#getprofile-data-params,#flow