This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Update NodeServices/SpaServices/NodeServices.Sockets to build using latest TypeScript and Webpack - #1748
Merged
Merged
Conversation
ryanbrandenburg
approved these changes
Aug 29, 2018
ryanbrandenburg
left a comment
Contributor
There was a problem hiding this comment.
I'm certainly no expert on TypeScript or WebPack, but it looks good to me.
Contributor
|
@SteveSandersonMS, this PR targeted master, we need it in release/2.2 as well. I'm going to cherry-pick them back. |
Member
Author
|
Do you need it in 2.2 though? It’s just build infrastructure, not changing the resulting product. |
Member
Author
|
Well I guess there’s no reason not to cherry-pick to 2.2 as well. It will help if we need to make changes in 2.x patches. |
ryanbrandenburg
pushed a commit
that referenced
this pull request
Aug 30, 2018
…atest TypeScript and Webpack (#1748)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously they assumed you were using versions of TypeScript and Webpack that are by now rather outdated. This PR:
package-lock.jsonfiles to lock down exactly which versions should be used, so it won't break in the future if TypeScript/Webpack themselves introduce breaking changes