Bugfixes to image morph and nearest neighbors - #1595
Conversation
- Fixes issues with erode and dilate at corner cases
|
@shehzan10 I am not making my PRs run tests run automatically. Can you launch and run the tests when possible |
|
build arrayfire linux ci |
Float values that are inf are outputted as inf to stringstream. However inf isn't available in opencl, causing min and max to fail. This alias is the easiest work around for now.
|
@shehzan10 you can kill old windows build. I missed something earlier by not testing OpenCL backend. |
|
@umar456 @shehzan10 May be the payoff is not that great, but that is something to consider going forward. |
| template<> __device__ short limit_max<short>() { return 0x7fff; } | ||
| template<> __device__ short limit_min<short>() { return 0x8000; } | ||
| template<> __device__ ushort limit_max<ushort>() { return ((ushort)1) << (8 * sizeof(ushort) - 1); } | ||
| template <typename T> __device__ T maxval() { return 1u << (8 * sizeof(T) - 1); } |
There was a problem hiding this comment.
I did not want it to be confused with numeric limits. I could change it back if you feel strongly about.
There was a problem hiding this comment.
Isn't it doing the same thing as numeric limits? If anything it should have the same interface.
There was a problem hiding this comment.
It has different behavior than numeric limits for floats and doubles. It had same behavior before, but this commit changed the behavior so I changed the name as well.
| s_dist[sid] = dist; | ||
| s_idx[sid] = s_idx[sid + i]; | ||
| } | ||
| __syncthreads(); |
There was a problem hiding this comment.
It was already like that (look at the left). I fixed it in one place but missed this. I'll fix it.
|
build arrayfire windows ci |
|
build arrayfire windows opencl ci |
|
@shehzan10 I missed the change in __syncthreads like @umar456 mentioned. Can you fix it in a different PR. BTW, it would also be better if you guys start commenting this as reviews. |
Uh oh!
There was an error while loading. Please reload this page.