Skip to content

Bug Fixes for 3.3.1 - #1314

Merged
shehzan10 merged 2 commits into
arrayfire:hotfix-3.3.1from
pavanky:fixes-3.3.1
Mar 4, 2016
Merged

Bug Fixes for 3.3.1#1314
shehzan10 merged 2 commits into
arrayfire:hotfix-3.3.1from
pavanky:fixes-3.3.1

Conversation

@pavanky

@pavanky pavanky commented Mar 3, 2016

Copy link
Copy Markdown
Member
  • Fixed getting device pointer out of OpenCL backend
  • Fixed unified backend to load SO versioned libraries

@pavanky pavanky added this to the 3.3.1 milestone Mar 3, 2016
@pavanky pavanky added the bug label Mar 3, 2016
Comment thread src/api/unified/symbol_manager.cpp Outdated
static const string LIB_AF_BKND_SUFFIX = ".3.dylib";
#else
static const string LIB_AF_BKND_SUFFIX = ".so";
static const string LIB_AF_BKND_SUFFIX = ".so.3";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavanky May be we can append the version number programmatically instead of hard coding it ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9prady9 That makes sense. Let me resend the PR.

@pavanky

pavanky commented Mar 3, 2016

Copy link
Copy Markdown
Member Author

@9prady9 updated.

@9prady9

9prady9 commented Mar 3, 2016

Copy link
Copy Markdown
Member

do you want to build it or shall i go ahead and merge it ?

@pavanky

pavanky commented Mar 3, 2016

Copy link
Copy Markdown
Member Author

@9prady9 build on linux and osx before merge.

@pavanky

pavanky commented Mar 3, 2016

Copy link
Copy Markdown
Member Author

build arrayfire linux ci

@pavanky

pavanky commented Mar 3, 2016

Copy link
Copy Markdown
Member Author

build arrayfire osx ci

@pavanky

pavanky commented Mar 4, 2016

Copy link
Copy Markdown
Member Author

build arrayfire linux ci

build arrayfire osx ci

@shehzan10

Copy link
Copy Markdown
Member

build arrayfire osx ci

shehzan10 added a commit that referenced this pull request Mar 4, 2016
@shehzan10
shehzan10 merged commit 63af426 into arrayfire:hotfix-3.3.1 Mar 4, 2016
@pavanky
pavanky deleted the fixes-3.3.1 branch March 4, 2016 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants