Revert registerUserKeys back to a synchronous API - #13896
Conversation
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13896 +/- ##
=========================================
Coverage 19.64% 19.65%
- Complexity 19784 19792 +8
=========================================
Files 6368 6368
Lines 574889 574859 -30
Branches 70353 70350 -3
=========================================
+ Hits 112935 112976 +41
+ Misses 449684 449610 -74
- Partials 12270 12273 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18874 |
|
@blueorangutan test |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
weizhouapache
left a comment
There was a problem hiding this comment.
lgtm
@bernardodemarco
could you please review and test it ? thanks
@weizhouapache, sure!!! |
|
@winterhazel, could you also remove this ending period from the following label, please? cloudstack/ui/public/locales/pt_BR.json Line 54 in 1cd2491 
|
@bernardodemarco ok. I'll also remove some API keypair-related UI labels that are not used anymore due to the latest changes. |
|
Last commit only included label changes. We can merge this one after the smoke tests in #13896 (comment) and a build success. |
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, tested the registerUserKeys and deleteUserKeys commands from both the CLI and UI
| }).catch(error => { | ||
| eventBus.emit('update-resource-state', { selectedItems: this.selectedItems, resource: keypair.id, state: 'failed' }) | ||
| } | ||
| this.$notifyError(error) |
There was a problem hiding this comment.
@winterhazel, should we return the plain error here? Or should we return a more generic message, similar to the error handling performed for the registerUserKeys command?
Description
#9504 made the
registerUserKeysAPI asynchronous without a valid reason. This PR reverts it to a synchronous API, in order to avoid changing how it is consumed.Additionally, the
deleteUserKeysAPI, introduced in #9504, was also made synchronous, as there's no reason for it being asynchronous.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?