build: update jasmine dependencies to v7 (main) - #33868
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This pull request upgrades jasmine and jasmine-core to version 7.0.0 across several package.json files. The feedback points out that the corresponding @types/jasmine dependencies should also be updated to ~7.0.0 to match the new major version and prevent potential TypeScript compilation errors.
| "husky": "9.1.7", | ||
| "jasmine": "~6.3.0", | ||
| "jasmine-core": "~6.3.0", | ||
| "jasmine": "~7.0.0", |
There was a problem hiding this comment.
When upgrading jasmine and jasmine-core to v7, the @types/jasmine dependency (currently at ~6.0.0 on line 81) should also be updated to ~7.0.0 to align type definitions with the new major version and avoid potential TypeScript compilation errors.
| "@types/node": "^20.17.19", | ||
| "@types/jasmine": "~6.0.0", | ||
| "jasmine": "^6.0.0" | ||
| "jasmine": "^7.0.0" |
There was a problem hiding this comment.
When upgrading jasmine to ^7.0.0, the @types/jasmine dependency (currently at ~6.0.0 on line 22) should also be updated to ~7.0.0 to align type definitions with the new major version and avoid potential TypeScript compilation errors.
| "@types/node": "^20.17.19", | ||
| "@types/jasmine": "~6.0.0", | ||
| "jasmine": "~6.3.0", | ||
| "jasmine": "~7.0.0", |
There was a problem hiding this comment.
When upgrading jasmine to ~7.0.0, the @types/jasmine dependency (currently at ~6.0.0 on line 21) should also be updated to ~7.0.0 to align type definitions with the new major version and avoid potential TypeScript compilation errors.
| "express": "^5.1.0", | ||
| "istanbul-lib-instrument": "^6.0.3", | ||
| "jasmine-core": "~6.3.0", | ||
| "jasmine-core": "~7.0.0", |
There was a problem hiding this comment.
When upgrading jasmine-core to ~7.0.0, the @types/jasmine dependency (currently at ~6.0.0 on line 7) should also be updated to ~7.0.0 to align type definitions with the new major version and avoid potential TypeScript compilation errors.
|
See #30575 . This should not be merged unless karma-jasmine is updated accordingly. |
This PR contains the following updates:
~6.3.0→~7.0.0^6.0.0→^7.0.0~6.3.0→~7.0.0Release Notes
jasmine/jasmine-npm (jasmine)
v7.0.0Compare Source
Please see the release notes.
jasmine/jasmine (jasmine-core)
v7.0.1Compare Source
Please see the release notes.
v7.0.0Compare Source
Please see the release notes.