feat(forms): add migration for AbstractControl.parent accesses - #39009
Closed
crisbeto wants to merge 2 commits into
Closed
feat(forms): add migration for AbstractControl.parent accesses#39009crisbeto wants to merge 2 commits into
crisbeto wants to merge 2 commits into
Conversation
crisbeto
marked this pull request as ready for review
September 27, 2020 05:29
AndrewKushnir
approved these changes
Sep 28, 2020
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Great work, thanks @crisbeto 👍
As of angular#32671, the type of `AbstractControl.parent` can be null which can cause compilation errors in existing apps. These changes add a migration that will append non-null assertions to existing unsafe accesses. ```` // Before console.log(control.parent.value); // After console.log(control.parent!.value); ``` The migration also tries its best to avoid cases where the non-null assertions aren't necessary (e.g. if the `parent` was null checked already).
crisbeto
force-pushed
the
abstract-control-parent-migration
branch
from
September 29, 2020 06:14
0f86d99 to
ba330c6
Compare
AndrewKushnir
approved these changes
Sep 29, 2020
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for addressing the feedback @crisbeto 👍
Contributor
Contributor
|
FYI, adding the "blocked" label for now since the type change should be merged first. |
Member
Author
|
The related forms PR has been merged in. I'm unblocking this one. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #32671, the type of
AbstractControl.parentcan be null which can cause compilation errors in existing apps. These changes add a migration that will append non-null assertions to existing unsafe accesses.The migration also tries its best to avoid cases where the non-null assertions aren't necessary (e.g. if the
parentwas null checked already).