Skip to content

The version of phpunit 6.* - #38

Closed
nikser wants to merge 2 commits into
allure-framework:masterfrom
nikser:master
Closed

The version of phpunit 6.*#38
nikser wants to merge 2 commits into
allure-framework:masterfrom
nikser:master

Conversation

@nikser

@nikser nikser commented Feb 12, 2018

Copy link
Copy Markdown

No description provided.

@CLAassistant

CLAassistant commented Feb 12, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency on "phpunit/phpunit": ">=6.0.0" allow us to use any version of phpunit staring from 6.0.0 but not limited with any higher version
proposed changes "phpunit/phpunit": "6.*" allow us to use any version of phpunit in range from >=6.0.0 to <7.0.0 which looks reasonable

@baev

baev commented Dec 18, 2018

Copy link
Copy Markdown
Member

but currently in master "phpunit/phpunit": ">=7.0.0" is specified

@okorshenko

Copy link
Copy Markdown

Hi @nikser
Thank you for your contribution. Could you please resolver conflict on composer.json file

@baev

baev commented Dec 18, 2018

Copy link
Copy Markdown
Member

I guess this change is outdated after 9399629

@baev baev closed this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants