Update namespace for Allure adapter - #45
Merged
Merged
Conversation
- Codeception allure adapter conflicting with PHPUnit allure adapter
|
|
okorshenko
approved these changes
Dec 17, 2018
okorshenko
left a comment
There was a problem hiding this comment.
Great! Thank you for this fix. This issue is very annoying
Member
|
@okolesnyk can we have the same updates as in allure-framework/allure-phpunit#42 ? |
Contributor
Author
|
@baev Sure thing. |
- Codeception allure adapter conflicting with PHPUnit allure adapter - Code review changes
baev
approved these changes
Dec 18, 2018
|
Thank you @baev for quick review and processing! Looking forward for new release! |
Member
|
1.3.0 should be available by now (both phpunit and codeception) |
Contributor
Author
|
Thank you @baev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding codeception to namespace we resolving issue: #44