Added MainActor annotations to the example group closures - #1300
Open
CraigSiemens wants to merge 2 commits into
Open
Added MainActor annotations to the example group closures#1300CraigSiemens wants to merge 2 commits into
CraigSiemens wants to merge 2 commits into
Conversation
CraigSiemens
force-pushed
the
more-main-actor
branch
from
September 9, 2024 03:22
ee7c62c to
13fccb1
Compare
Contributor
Author
|
It looks like the builds are failing because of the call to Some of those workflows would need to be updated to use newer versions of Xcode and Swift. I'm no sure if that's something that should be done in this PR or another one. |
Contributor
|
Any updates on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1298
This adds
@MainActorannotations to thedescribeandcontextclosures as well asQuickSpec.spec().This helps resolve a warning when using Swift 6 with complete concurrency checking enabled when a variable is defined in
spec()or an example group (describe/context) and used in a test. The compiler would warn when accessing a non-isolated variable from an isolated context (it). Now everything has the same isolation.