fix-next: correct raising of layoutChanged event - #6457
Merged
Conversation
Currently the layoutChanged event can be raised even when there is no change due to safe area calculations.
|
Please sign CLA at http://www.nativescript.org/cla |
|
CLA signature found, happy contributing! |
MartoYankov
approved these changes
Oct 26, 2018
dtopuzov
pushed a commit
that referenced
this pull request
Oct 29, 2018
Currently the layoutChanged event can be raised even when there is no change due to safe area calculations.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently the layoutChanged event can be raised even when there is no change due to safe area calculations.
What is the new behavior?
The check if the frame is actually changed is performed before the safe area transformations are applied.
Fixes/Implements/Closes #[Issue Number].