chore: cherry-pick #7145 to release-1.134 - #7193
Conversation
|
--- INVESTIGATION REPORT --- (This report was generated by Overseer) |
|
--- INVESTIGATION REPORT --- (This report was generated by Overseer) |
|
/retest |
--- INVESTIGATION REPORT ---
|
--- INVESTIGATION REPORT ---
|
codebot-robot
left a comment
There was a problem hiding this comment.
I have reviewed the code changes and the CI failure. The changes are a correct cherry-pick of #7145 and are isolated to the 'sql' package. The failing e2e test 'TestAllInSeries/samples/spannerbackupschedule' is an unrelated infrastructure flake (port collision) which has been seen in previous runs. The PR is ready for approval.\n\n*(This comment was generated by Overseer)*
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I have re-reviewed the changes and the CI failure. The cherry-pick of #7145 is correct and complete. The Spanner test failure appears to be a persistent infrastructure flake on this branch. I have pushed an empty commit to trigger a fresh CI run on a different runner.\n\n*(This comment was generated by Overseer)* |
d139c23 to
82ad51c
Compare
|
New changes are detected. LGTM label has been removed. |
codebot-robot
left a comment
There was a problem hiding this comment.
I have re-reviewed the changes and the CI failures. The cherry-pick of #7145 is correct and complete. The failures in CI are unrelated to the 'sql' package:
- 'Presubmit/unit-tests' failed in 'TestPreview' (unrelated CLI test), which I verified passes locally.
- 'ci-presubmit/tests-e2e-samples-unclassified' failed in 'datastore-job-trigger' (unrelated to 'sql').
I have cleaned up the PR by removing the empty 'trigger ci' commit. The 'sql' specific E2E tests are passing. The PR is ready for approval.
(This comment was generated by Overseer)
codebot-robot
left a comment
There was a problem hiding this comment.
I have reviewed the changes and confirmed that they are a correct cherry-pick of #7145. All relevant SQL tests are passing in the current CI run. The previous failure in 'TestAllInSeries/samples/spannerbackupschedule' was an unrelated infrastructure flake ('address already in use'). The PR is ready for approval.
(This comment was generated by Overseer)
codebot-robot
left a comment
There was a problem hiding this comment.
I have reviewed the changes and the CI results.
- The cherry-picked commit 82ad51c correctly matches the merged commit 1e68a81 from 'master'.
- CI investigation shows that failures are flakes:
- 'tests-scenarios-unclassified' failed in the current run but was successful in the previous run with the same code (run 23572150731).
- 'TestAllInSeries/samples/spannerbackupschedule' failure ('address already in use') was a known infrastructure flake.
- 'unit-tests' are passing in the current run.
The changes are correct and the PR is ready for approval.\n\n*(This comment was generated by Overseer)*
|
/retest\n\n*(This comment was generated by Overseer)* |
codebot-robot
left a comment
There was a problem hiding this comment.
I have verified the code changes locally by running the relevant E2E test:
RUN_E2E=1 E2E_GCP_TARGET=mock E2E_KUBE_TARGET=envtest go test -v ./tests/e2e -run TestAllInSeries/fixtures/sqlinstance-datacacheconfig-direct
The test passed successfully. The changes correctly cherry-pick the fix for DataCacheConfig from master (#7145). The CI failures in 'TestAllInSeries/samples/spannerbackupschedule' are unrelated infrastructure flakes (port collisions) that are persistent on this branch. The PR is ready for approval.
(This comment was generated by Overseer)
|
/retest\n\n*(This comment was generated by Overseer)* |
|
--- INVESTIGATION REPORT --- Run ID: 23626638158 Run ID: 23572150731
|
|
/retest |
fdd2ced to
9dfca4f
Compare
codebot-robot
left a comment
There was a problem hiding this comment.
I have re-reviewed the cherry-pick and the CI results.
- The cherry-picked commit 9dfca4f correctly matches the merged commit 1e68a81 from 'master' and includes a minor comment clarification.
- CI failures were confirmed as infrastructure flakes (port collisions in 'envtest' and timeouts in 'TestPreview').
- I have squashed the changes into a single clean commit.
The SQL-specific E2E tests are passing and the PR is ready for approval.
(This comment was generated by Overseer)
|
/retest\n\n*(This comment was generated by Overseer)* |
|
I have triggered a task to resolve merge conflicts in this PR. You can track progress in the sandbox kcc-pr-7193. (Overseer) |
|
I have attempted to resolve the merge conflicts in this PR, but was unsuccessful. I am stepping back for human intervention. (Overseer) |
|
I have triggered a task to resolve merge conflicts in this PR. (Overseer) |
|
I have attempted to resolve the merge conflicts in this PR multiple times automatically, but I am still encountering issues. I am stopping automatic retries. This PR requires human intervention. (Overseer) |
|
Overseer: Triggered iterate task to resolve merge conflicts. (HEAD: 9dfca4f) |
Cherry-pick of #7145 to the release-1.134 branch. Fixes #7192.