Fix(community/slinky): add missing instructions output variable - #5787
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a validation error in the hpc-slinky blueprint by ensuring the required 'instructions' output variable is properly exported by the slinky module. This change facilitates better user experience by providing clear post-deployment connectivity and testing steps for the Slurm environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new instructions output to the Slinky scheduler module, detailing how to connect to the cluster and run basic Slurm commands, and updates the README documentation accordingly. The reviewer suggests adding a depends_on block to this new output to ensure it is only evaluated after all Helm releases are fully deployed, which prevents potential race conditions.
… slurm-gke blueprint
|
Hi @SwarnaBharathiMantena , thanks for fixing this ? May i know what is the root cause for this ? Basically wanted to understand how validation started failing suddenly? |
|
can you also please run the PR test for same |
|
PR-test-slurm-gke test passed on the PR. |
5c8e8de
into
GoogleCloudPlatform:develop
This PR fixes a validation error in the community module
hpc-slinkyblueprint (hpc-slinky.yaml). The blueprint expects aninstructionsoutput variable to be exported by theslinkymodule to display post-deployment steps, but that variable was missing fromcommunity/modules/scheduler/slinky/outputs.tf.