Skip to content

(GKE) Remove ML Diagnostics module - #5748

Merged
AdarshK15 merged 3 commits into
GoogleCloudPlatform:developfrom
AdarshK15:deprecate-mldiagnostics
Jun 15, 2026
Merged

(GKE) Remove ML Diagnostics module#5748
AdarshK15 merged 3 commits into
GoogleCloudPlatform:developfrom
AdarshK15:deprecate-mldiagnostics

Conversation

@AdarshK15

@AdarshK15 AdarshK15 commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

With GKE-managed ML Diagnostics feature, we can configure gke-cluster to natively install ML Diagnostics related charts for GKE version 1.35.0-gke.3065000 or higher. To simplify maintenance, this PR removes the module mldiagnostics which manually installs charts.

Key Changes

  • Module removal: Deleted the mldiagnostics module and its associated files, as they are no longer needed.
  • Rename variable: Shortened variable name enable_managed_ml_diagnostics to just enable_ml_diagnostics for a cleaner setup in the gke-cluster module and blueprints.
  • Test relocation: Moved the sample workload tests from the deleted module to examples/gke-tpu-v6e/ml-diagnostics-sample-workload-test/ .

Usage Example

To enable GKE managed ML Diagnostics, set enable_ml_diagnostics to true in gke-cluster module:

  - id: gke-tpu-v6e-cluster
    source: modules/scheduler/gke-cluster
    settings:
      configure_workload_identity_sa: true
      namespace: $(vars.user_namespace)
      enable_ml_diagnostics: true

@AdarshK15 AdarshK15 added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Jun 7, 2026
@gemini-code-assist

gemini-code-assist Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the GKE ML Diagnostics configuration by deprecating the manual 'mldiagnostics' module in favor of native GKE support. The changes include renaming configuration variables for clarity and relocating test assets to improve the project structure and maintainability.

Highlights

  • Module Removal: Deleted the 'mldiagnostics' module as GKE now provides native support for ML Diagnostics in version 1.35.0-gke.3065000 and higher.
  • Variable Renaming: Simplified the configuration variable 'enable_managed_ml_diagnostics' to 'enable_ml_diagnostics' across all modules and example files.
  • Test Relocation: Moved sample workload tests from the removed module to 'examples/gke-tpu-v6e/ml-diagnostics-sample-workload-test/' to maintain test coverage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 7, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the manual 'mldiagnostics' module and renames 'enable_managed_ml_diagnostics' to 'enable_ml_diagnostics' across the GKE cluster module and blueprints. The documentation and tests are updated accordingly. The reviewer correctly noted that a precondition error message in 'modules/scheduler/gke-cluster/main.tf' still obsolete-ly references the deleted 'mldiagnostics' module, which should be cleaned up.

Comment thread modules/scheduler/gke-cluster/main.tf
annuay-google
annuay-google reviewed Jun 8, 2026
View reviewed changes
Comment thread examples/gke-tpu-7x/gke-tpu-7x-advanced.yaml
annuay-google
annuay-google previously approved these changes Jun 8, 2026
View reviewed changes
LAVEEN
LAVEEN previously approved these changes Jun 8, 2026
View reviewed changes

@LAVEEN LAVEEN left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SwarnaBharathiMantena
SwarnaBharathiMantena previously approved these changes Jun 8, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdarshK15
AdarshK15 force-pushed the deprecate-mldiagnostics branch from e17b8e2 to b6c606d Compare June 14, 2026 07:38
@AdarshK15
AdarshK15 marked this pull request as ready for review June 15, 2026 05:41
@AdarshK15
AdarshK15 requested a review from a team as a code owner June 15, 2026 05:41
@AdarshK15
AdarshK15 merged commit f956d86 into GoogleCloudPlatform:develop Jun 15, 2026
21 of 84 checks passed
ksaishree pushed a commit to ksaishree/cluster-toolkit that referenced this pull request Jun 18, 2026
@AdarshK15 @ksaishree
(GKE) Remove ML Diagnostics module (GoogleCloudPlatform#5748)
d995bd5
Neelabh94 pushed a commit to Neelabh94/cluster-toolkit that referenced this pull request Jun 18, 2026
@AdarshK15 @Neelabh94
(GKE) Remove ML Diagnostics module (GoogleCloudPlatform#5748)
bf1d1fe
@AdarshK15
AdarshK15 deleted the deprecate-mldiagnostics branch June 20, 2026 14:55
ep-nag pushed a commit to nagconsulting/cluster-toolkit that referenced this pull request Aug 7, 2026
@AdarshK15
(GKE) Remove ML Diagnostics module (GoogleCloudPlatform#5748)
30b66e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes
@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena left review comments
@annuay-google annuay-google annuay-google left review comments
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AdarshK15 @LAVEEN @SwarnaBharathiMantena @annuay-google