-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
3.0 performance degraded due to locking #20286
Copy link
Copy link
Closed
Labels
backlog fixThe issue was closed as part of the backlog reduction initiative.The issue was closed as part of the backlog reduction initiative.branch: 3.0Applies to openssl-3.0 branchApplies to openssl-3.0 branchbranch: 3.1Applies to openssl-3.1 (EOL)Applies to openssl-3.1 (EOL)branch: 3.2Applies to openssl-3.2 (EOL)Applies to openssl-3.2 (EOL)branch: masterApplies to master branchApplies to master branchhelp wantedWe depend on community to resolve this issue.We depend on community to resolve this issue.triaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bugtriaged: performanceThe issue/pr reports/fixes a performance concernThe issue/pr reports/fixes a performance concerntriaged: refactorThe issue/pr requests/implements refactoringThe issue/pr requests/implements refactoring
Description
Metadata
Metadata
Assignees
Labels
backlog fixThe issue was closed as part of the backlog reduction initiative.The issue was closed as part of the backlog reduction initiative.branch: 3.0Applies to openssl-3.0 branchApplies to openssl-3.0 branchbranch: 3.1Applies to openssl-3.1 (EOL)Applies to openssl-3.1 (EOL)branch: 3.2Applies to openssl-3.2 (EOL)Applies to openssl-3.2 (EOL)branch: masterApplies to master branchApplies to master branchhelp wantedWe depend on community to resolve this issue.We depend on community to resolve this issue.triaged: bugThe issue/pr is/fixes a bugThe issue/pr is/fixes a bugtriaged: performanceThe issue/pr reports/fixes a performance concernThe issue/pr reports/fixes a performance concerntriaged: refactorThe issue/pr requests/implements refactoringThe issue/pr requests/implements refactoring
Using some internal QUIC tests, we see this timing in 1.1:
In 3.0 we see this:
This seems to be part of
OSSL_DECODER_CTX_new_for_pkey16% of the time is spent in locking, on a single threaded binary. And 10% is in a string hashtable lookup.If anyone on the project is going to look at this, I will try to get a small reproducer. But our the time for our QUIC tests is doubling.