Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Commit 5e50beb

Browse files
asthamohtaasthamohta
authored
fix: fix for database name in batch create request (#883)
* tests * changes
1 parent 131964e commit 5e50beb

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎google/cloud/spanner_v1/pool.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def bind(self, database):
193193
metadata = _metadata_with_prefix(database.name)
194194
self._database_role = self._database_role or self._database.database_role
195195
request = BatchCreateSessionsRequest(
196-
database=database.database_id,
196+
database=database.name,
197197
session_count=self.size - self._sessions.qsize(),
198198
session_template=Session(creator_role=self.database_role),
199199
)
@@ -406,7 +406,7 @@ def bind(self, database):
406406
self._database_role = self._database_role or self._database.database_role
407407

408408
request = BatchCreateSessionsRequest(
409-
database=database.database_id,
409+
database=database.name,
410410
session_count=self.size - created_session_count,
411411
session_template=Session(creator_role=self.database_role),
412412
)

‎tests/system/test_database_api.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def test_database_binding_of_fixed_size_pool(
9797
default_timeout=500,
9898
database_role="parent",
9999
)
100-
database = shared_instance.database(temp_db.name, pool=pool)
100+
database = shared_instance.database(temp_db_id, pool=pool)
101101
assert database._pool.database_role == "parent"
102102

103103

@@ -125,7 +125,7 @@ def test_database_binding_of_pinging_pool(
125125
ping_interval=100,
126126
database_role="parent",
127127
)
128-
database = shared_instance.database(temp_db.name, pool=pool)
128+
database = shared_instance.database(temp_db_id, pool=pool)
129129
assert database._pool.database_role == "parent"
130130

131131

0 commit comments

Comments
 (0)