Skip to content

Commit 7863e78

Browse files
rosborosbo
committed
Use single quote whenever possible
1 parent f924d1c commit 7863e78

6 files changed

Lines changed: 25 additions & 25 deletions

File tree

‎build‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ Options:
1212
EOF
1313
}
1414

15-
CACHE_FLAG="--no-cache"
16-
DOCKERFILE="Dockerfile"
17-
IMAGE_TAG="kaggle/python-build"
15+
CACHE_FLAG='--no-cache'
16+
DOCKERFILE='Dockerfile'
17+
IMAGE_TAG='kaggle/python-build'
1818

1919
while :; do
2020
case "$1" in
@@ -23,11 +23,11 @@ while :; do
2323
exit
2424
;;
2525
-g|--gpu)
26-
IMAGE_TAG="kaggle/python-gpu-build"
27-
DOCKERFILE="gpu.Dockerfile"
26+
IMAGE_TAG='kaggle/python-gpu-build'
27+
DOCKERFILE='gpu.Dockerfile'
2828
;;
2929
-c|--use-cache)
30-
CACHE_FLAG=""
30+
CACHE_FLAG=''
3131
;;
3232
-?*)
3333
usage

‎diff‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ EOF
1212
}
1313

1414

15-
BASE_IMAGE_TAG="gcr.io/kaggle-images/python:latest"
16-
TARGET_IMAGE_TAG="kaggle/python-build"
15+
BASE_IMAGE_TAG='gcr.io/kaggle-images/python:latest'
16+
TARGET_IMAGE_TAG='kaggle/python-build'
1717

1818
while :; do
1919
case "$1" in
@@ -22,8 +22,8 @@ while :; do
2222
exit
2323
;;
2424
-g|--gpu)
25-
BASE_IMAGE_TAG="gcr.io/kaggle-private-byod/python:latest"
26-
TARGET_IMAGE_TAG="kaggle/python-gpu-build"
25+
BASE_IMAGE_TAG='gcr.io/kaggle-private-byod/python:latest'
26+
TARGET_IMAGE_TAG='kaggle/python-gpu-build'
2727
;;
2828
-?*)
2929
usage
@@ -51,5 +51,5 @@ for cmd in "${CMDS[@]}"; do
5151
diff --suppress-common-lines --side-by-side \
5252
<(docker run --rm "$BASE_IMAGE_TAG" $cmd) \
5353
<(docker run --rm "$TARGET_IMAGE_TAG" $cmd) \
54-
&& echo "No diff" || true
54+
&& echo 'No diff' || true
5555
done

‎push‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ Options:
1111
EOF
1212
}
1313

14-
SOURCE_IMAGE="kaggle/python-build"
15-
TARGET_IMAGE="gcr.io/kaggle-images/python"
14+
SOURCE_IMAGE='kaggle/python-build'
15+
TARGET_IMAGE='gcr.io/kaggle-images/python'
1616

1717
while :; do
1818
case "$1" in
@@ -21,8 +21,8 @@ while :; do
2121
exit
2222
;;
2323
-g|--gpu)
24-
SOURCE_IMAGE="kaggle/python-gpu-build"
25-
TARGET_IMAGE="gcr.io/kaggle-private-byod/python"
24+
SOURCE_IMAGE='kaggle/python-gpu-build'
25+
TARGET_IMAGE='gcr.io/kaggle-private-byod/python'
2626
;;
2727
-?*)
2828
usage

‎tensorflow-whl/build‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ Options:
1111
EOF
1212
}
1313

14-
CACHE_FLAG="--no-cache"
15-
IMAGE_TAG="kaggle/python-tensorflow-whl"
14+
CACHE_FLAG='--no-cache'
15+
IMAGE_TAG='kaggle/python-tensorflow-whl'
1616

1717
while :; do
1818
case "$1" in
@@ -21,7 +21,7 @@ while :; do
2121
exit
2222
;;
2323
-c|--use-cache)
24-
CACHE_FLAG=""
24+
CACHE_FLAG=''
2525
;;
2626
-?*)
2727
usage

‎tensorflow-whl/push‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ EOF
1111

1212
set -x
1313

14-
SOURCE_IMAGE="kaggle/python-tensorflow-whl"
15-
TARGET_IMAGE="gcr.io/kaggle-images/python-tensorflow-whl"
14+
SOURCE_IMAGE='kaggle/python-tensorflow-whl'
15+
TARGET_IMAGE='gcr.io/kaggle-images/python-tensorflow-whl'
1616

1717
while :; do
1818
case "$1" in
@@ -35,7 +35,7 @@ done
3535
LABEL=$1
3636

3737
if [[ -z "$LABEL" ]]; then
38-
echo "You must provide a label for the image"
38+
echo 'You must provide a label for the image'
3939
exit 1
4040
fi
4141

‎test‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ Options:
1212
EOF
1313
}
1414

15-
IMAGE_TAG="kaggle/python-build"
16-
ADDITONAL_OPTS=""
15+
IMAGE_TAG='kaggle/python-build'
16+
ADDITONAL_OPTS=''
1717

1818
while :; do
1919
case "$1" in
@@ -22,8 +22,8 @@ while :; do
2222
exit
2323
;;
2424
-g|--gpu)
25-
IMAGE_TAG="kaggle/python-gpu-build"
26-
ADDITONAL_OPTS="-v /tmp/empty_dir:/usr/local/cuda/lib64/stubs:ro"
25+
IMAGE_TAG='kaggle/python-gpu-build'
26+
ADDITONAL_OPTS='-v /tmp/empty_dir:/usr/local/cuda/lib64/stubs:ro'
2727
;;
2828
-?*)
2929
usage

0 commit comments

Comments
 (0)