Skip to content

Feat: Onboard NHTSA Traffic Fatalities dataset - #454

Merged
nlarge-google merged 16 commits into
GoogleCloudPlatform:mainfrom
aurogoogle:nhtsa_traffic_fatalities
Aug 25, 2022
Merged

Feat: Onboard NHTSA Traffic Fatalities dataset#454
nlarge-google merged 16 commits into
GoogleCloudPlatform:mainfrom
aurogoogle:nhtsa_traffic_fatalities

Conversation

@aurogoogle

@aurogoogle aurogoogle commented Aug 22, 2022

Copy link
Copy Markdown
Contributor

Description

Dataset: NHTSA Traffic Fatalities

Checklist

  • (Required) This pull request is appropriately labeled
  • Please merge this pull request after it's approved

Use the sections below based on what's applicable to your PR and delete the rest:

Feature

  • I'm adding or editing a feature
  • I have updated the README accordingly

Data Onboarding

  • I'm adding or editing a dataset
  • The Google Cloud Datasets team is aware of the proposed dataset
  • I put all my code inside datasets/<nhtsa_traffic_fatalities> and nothing outside of that directory

@aurogoogle aurogoogle changed the title Feat : Onboard NHTSA Traffic Fatalities Dataset feat : Onboard NHTSA Traffic Fatalities Dataset Aug 22, 2022
@aurogoogle aurogoogle changed the title feat : Onboard NHTSA Traffic Fatalities Dataset Feat: Onboard NHTSA Traffic Fatalities Dataset Aug 22, 2022
@aurogoogle aurogoogle changed the title Feat: Onboard NHTSA Traffic Fatalities Dataset Feat: Onboard NHTSA Traffic Fatalities dataset Aug 22, 2022
@aurogoogle aurogoogle self-assigned this Aug 22, 2022
@aurogoogle aurogoogle added the data onboarding Onboard a dataset or submit a pipeline label Aug 22, 2022
@aurogoogle

Copy link
Copy Markdown
Contributor Author

@adlersantos @nlarge-google Kindly review.

@nlarge-google nlarge-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job, just removal of blank lines.

Comment thread Pipfile Outdated
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the branch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the mentioned file from the commit / branch.

Comment thread Pipfile.lock Outdated
@@ -0,0 +1,20 @@
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the branch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the mentioned file from the commit / branch.

+ "00"
+ " UTC"
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra lines

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra spaces.

append_batch_file(
target_file_batch, target_file, skip_header, not (skip_header)
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra lines

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra spaces.

@aurogoogle
aurogoogle force-pushed the nhtsa_traffic_fatalities branch from d515289 to 2bd4fcd Compare August 25, 2022 13:20
@aurogoogle

Copy link
Copy Markdown
Contributor Author

Hey @nlarge-google I have addressed the mentioned changes. Kindly review.

@nlarge-google

Copy link
Copy Markdown
Contributor

Great Job!

@nlarge-google
nlarge-google merged commit eb409c4 into GoogleCloudPlatform:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data onboarding Onboard a dataset or submit a pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants