Feat: Onboard Human Variant Annotation dataset - #438
Merged
nlarge-google merged 6 commits intoAug 25, 2022
Merged
Conversation
nlarge-google
suggested changes
Aug 10, 2022
nlarge-google
left a comment
Contributor
There was a problem hiding this comment.
Minor changes. Please make the changes and retest.
| gcs_bucket: str, | ||
| target_gcs_folder: str, | ||
| pipeline: str, | ||
| ): |
Contributor
There was a problem hiding this comment.
Always incorporate a return type. For no return type use:
def fn(...) -> None:
| source_url = base_url + f"archive_{version}/{date_time.strftime('%Y')}/{file_name}" | ||
| source_file = f"./files/{folder}/{file_name}" | ||
| status_code = download_gzfile(source_url, source_file) | ||
| if status_code == 200: |
| folder: pathlib.Path, | ||
| gcs_bucket: str, | ||
| target_gcs_folder: str, | ||
| ): |
nlarge-google
approved these changes
Aug 25, 2022
nlarge-google
left a comment
Contributor
There was a problem hiding this comment.
Great Job. In future though, please reduce the number of blank lines between code blocks to 0. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dataset: human_variant_annotation pipeline: clinvar
Dataset: human_variant_annotation pipeline: db_snp
Checklist
datasets/human_variant_annotationand nothing outside of that directory