feat(secrets): reveal visible values to members - #7231
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR allows Credential Members to deliberately reveal workspace secrets whose visibility setting is enabled while preserving read-only access.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secret-value-field/secret-value-field.tsx | Replaces browser-specific CSS masking with fixed bullet content and independently controls reveal and edit permissions. |
| apps/sim/app/api/workspaces/[id]/environment/route.ts | Reveals unredacted workspace values only when the environment snapshot identifies the key as accessible to the caller. |
| apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secrets-manager/secrets-manager.tsx | Enables reveal and detail navigation for authorized read-only credential members while retaining admin-only editing. |
| apps/sim/app/workspace/[workspaceId]/settings/secrets/[credentialId]/secret-detail.tsx | Allows read-only reveal on the detail page when the workspace credential is configured as unredacted. |
| apps/sim/hooks/queries/environment.ts | Stops retaining a prior workspace’s environment data while another workspace query loads. |
| apps/sim/hooks/queries/workspace.ts | Stops retaining a prior workspace’s permissions while another workspace query loads. |
Reviews (3): Last reviewed commit: "fix(secrets): reveal legacy values safel..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
6b2f125 to
4f0d2f5
Compare
|
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
bunx vitest run "app/api/workspaces/[id]/environment/route.test.ts" "app/workspace/[workspaceId]/settings/components/secrets/components/secret-value-field/secret-value-field.test.tsx"(10 tests)bun run lintbun run check:auditsbun run docs-manifest:checkbun run type-checkChecklist