Skip to content

fix(canvas): show full Agent prompt tooltips - #6961

Merged
icecrasher321 merged 1 commit into
stagingfrom
fix/canvas-tooltip-full-value
Aug 28, 2026
Merged

fix(canvas): show full Agent prompt tooltips#6961
icecrasher321 merged 1 commit into
stagingfrom
fix/canvas-tooltip-full-value

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Aug 22, 2026 •
edited by icecrasher321
Loading

Copy link
Copy Markdown
Contributor

Summary

Separates compact canvas display values from tooltip labels so long Agent prompts are no longer shortened before the tooltip receives them. Agent cards keep the existing 50-character first-message preview, block sizing, and auto-layout behavior, while editor and read-only preview tooltips receive the complete first-message content. Long plain strings such as Function code remain unchanged.

The renderer now supports an optional full tooltip value and opens the tooltip when the visible text is clipped or when it was shortened upstream. Password masking, selector hydration, regular row tooltip behavior, and structured-value summaries are unchanged.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other

Testing

  • bun run test lib/workflows/subblocks/display.test.ts in apps/sim: 28 tests passed
  • bun run test src/workflow-block/sub-block-row-view.test.tsx in packages/workflow-renderer: 1 test passed
  • bun run type-check in apps/sim
  • bun run type-check in packages/workflow-renderer
  • Scoped Biome check across all 7 changed files
  • git diff --check

Reviewers should focus on the display-versus-tooltip separation: the compact Agent chip must remain unchanged while its tooltip exposes the complete first message, including when the compact string itself fits and was truncated upstream.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Before behavior and both comparison screenshots are in the linked Slack thread. No after screenshot is attached because the compact preview and layout intentionally remain visually unchanged; only the tooltip content changes, and that behavior is covered by the focused renderer regression test.

@vercel

vercel Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 6:59pm

Request Review

@BillLeoutsakosvl346
BillLeoutsakosvl346 marked this pull request as ready for review August 22, 2026 02:17
@cursor

cursor Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only display/tooltip split with no layout, auth, or data-handling changes. Masking and non-message values keep existing behavior.

Overview
Agent message chips stay compact (50-character first-message preview), but hover tooltips now show the full first-message content instead of the already-truncated string.

Adds getTooltipDisplayValue for message arrays (including JSON-serialized ones) and an optional tooltipValue on OverflowSpan / SubBlockRowView. The tooltip opens when text is clipped or when the visible value was shortened upstream. Editor canvas and read-only preview both pass this through for messages-input; passwords, selector hydration, and long plain strings (e.g. Function code) are unchanged.

Reviewed by Cursor Bugbot for commit 2a74c4b. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR moves Agent-message clipping responsibility from getDisplayValue to the renderer so tooltips can receive the complete first message while the canvas remains compact.

  • Returns full trimmed content for message arrays and serialized message arrays.
  • Adds regression coverage for both input forms.
  • Leaves rendered chip width and layout estimation bounded independently of message length.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed
Filename Overview
apps/sim/lib/workflows/subblocks/display.ts Removes upstream 50-character truncation for message arrays; downstream rendering and layout measurement retain their existing width constraints.
apps/sim/lib/workflows/subblocks/display.test.ts Verifies that direct and serialized message arrays expose the complete first-message content.

Reviews (2): Last reviewed commit: "fix(canvas): show full Agent prompt tool..." | Re-trigger Greptile

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author
image

@icecrasher321
icecrasher321 force-pushed the fix/canvas-tooltip-full-value branch from 2a74c4b to c614533 Compare August 28, 2026 18:59
@icecrasher321

icecrasher321 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

@greptile

@icecrasher321

icecrasher321 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

@cubic-dev-ai please re-review the latest changes.

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic-dev-ai please re-review the latest changes.

@icecrasher321 Incremental reviews are turned off for this repository. Comment @cubic review to run a full review.

@icecrasher321

icecrasher321 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic review

@icecrasher321 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Aug 28, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321
icecrasher321 merged commit 0f3d5e5 into staging Aug 28, 2026
27 checks passed
@icecrasher321
icecrasher321 deleted the fix/canvas-tooltip-full-value branch August 28, 2026 19:07
@TheodoreSpeaks TheodoreSpeaks mentioned this pull request Aug 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BillLeoutsakosvl346 @icecrasher321