Fixed - offline slaves and sentinels shouldn't be connected during Sentinel startup. #7286 - #7289
Open
junsj119 wants to merge 1 commit into
Open
Fixed - offline slaves and sentinels shouldn't be connected during Sentinel startup. #7286#7289junsj119 wants to merge 1 commit into
junsj119 wants to merge 1 commit into
Conversation
…laves and sentinels during Sentinel startup. redisson#7286 Signed-off-by: junsj119 <wjstjddud119@naver.com>
junsj119
force-pushed
the
fix/sentinel-startup-offline-nodes
branch
from
August 8, 2026 10:33
bf3d1bf to
8de3dfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7286.
The Sentinel startup path in
SentinelConnectionManagerstill used the pre-#7004 ordering, unlike the periodic checks that were corrected in #7004:resolveIP(host, port).join()ran before theisDown(...)check, so an offline replica whose hostname no longer resolves (e.g. a scaled-down k8s pod) threw during startup.SENTINEL SENTINELSwas resolved and connected unconditionally, so stale entries pointing at dead addresses each cost a full connect timeout.Mirror the periodic-check behavior (
checkSlavesChange/checkSentinelsChange) in the startup loops: checkisDown(...)first and skip offline slaves and sentinels before resolving and connecting.