[DevTools] Guard overrideSuspenseMilestone against unknown renderer ids - #37370
[DevTools] Guard overrideSuspenseMilestone against unknown renderer ids#37370VaggelisGian wants to merge 1 commit into
Conversation
The handler indexed _rendererInterfaces directly, so a stale renderer id from the front-end threw inside Bridge listener dispatch and could break queued messages. Warn and bail out instead, matching the other override handlers. Test Plan: yarn test-build-devtools packages/react-devtools-shared/src/__tests__/backend-test.js -t overrideSuspenseMilestone with fix reverted: TypeError reading supportsTogglingSuspense at agent.js:793 with fix applied: 2 passed, 2 total (full file) eslint clean; prettier clean; flow dom-node check: No errors!
|
Hi @VaggelisGian! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Agent.overrideSuspenseMilestoneindexed_rendererInterfacesdirectly, so a stale renderer ID from the front-end threwCannot read properties of undefined (reading 'supportsTogglingSuspense')inside the Bridge's synchronous listener dispatch, which can also break later queued messages in the same tick. Warn and bail out instead, matching the other override handlers on this class.How did you test this change?
TypeError: Cannot read properties of undefined (reading 'supportsTogglingSuspense')at agent.js:793