Skip to content

Add Parameter read_file_handle to InputFile - #4388

Merged
Bibo-Joshi merged 10 commits into
masterfrom
bug/large-files
Aug 2, 2024
Merged

Add Parameter read_file_handle to InputFile#4388
Bibo-Joshi merged 10 commits into
masterfrom
bug/large-files

Conversation

@Bibo-Joshi

Copy link
Copy Markdown
Member

When ready, closes #4339

@Bibo-Joshi
Bibo-Joshi marked this pull request as ready for review July 22, 2024 20:00

@harshil21 harshil21 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also edit the wiki page to mention this, it can be easily overlooked.

Comment thread tests/request/test_request.py Outdated
@Bibo-Joshi

Copy link
Copy Markdown
Member Author

we should also edit the wiki page to mention this, it can be easily overlooked.

good point. Added notes at

https://github.com/python-telegram-bot/dev-wiki/wiki/Working-with-Files-and-Media

and

https://github.com/python-telegram-bot/dev-wiki/wiki/Local-Bot-API-Server

@Bibo-Joshi
Bibo-Joshi merged commit 3a49372 into master Aug 2, 2024
@Bibo-Joshi
Bibo-Joshi deleted the bug/large-files branch August 2, 2024 20:28
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2024
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug 🔌 enhancement pr description: enhancement and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug 🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The libary sometimes cannot send files over 800MB with local bot server.[BUG]

2 participants