Skip to content

Fix accidental wrong renaming in #3223 - #3380

Merged
Bibo-Joshi merged 3 commits into
masterfrom
fix-download-namings
Nov 24, 2022
Merged

Fix accidental wrong renaming in #3223#3380
Bibo-Joshi merged 3 commits into
masterfrom
fix-download-namings

Conversation

@Bibo-Joshi

Copy link
Copy Markdown
Member

See https://t.me/pythontelegrambotgroup/639703

Checklist for PRs

  • [x] Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • [x] Documented code changes according to the CSI standard
  • [x] Added myself alphabetically to AUTHORS.rst (optional)
  • [x] Added new classes & modules to the docs and all suitable __all__ s

@harshil21 harshil21 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now makes sense (how did we all miss this?). Any other references should have been caught by tests and doc build.

wiki probably also needs updating, so adding label

@harshil21 harshil21 added the ℹ️ needs-wiki-update information: needs-wiki-update label Nov 22, 2022
@harshil21 harshil21 added this to the v20.0a6 milestone Nov 22, 2022
Comment thread telegram/_files/file.py
@Bibo-Joshi
Bibo-Joshi merged commit 05c6ca0 into master Nov 24, 2022
@Bibo-Joshi
Bibo-Joshi deleted the fix-download-namings branch November 24, 2022 11:09
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 1, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🔌 bug pr description: bug ℹ️ needs-wiki-update information: needs-wiki-update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants