Pathlib weherever possible 2665 by eldbud · Pull Request #2688 · python-telegram-bot/python-telegram-bot

eldbud · 2021-10-02T01:47:37Z

Refactored usage of str objects and/or os module can be replaced with pathlib.Path across the project.
Hopefully managed to find all places in the project that can be updated.

…ryptionError (python-telegram-bot#2621) * move telegramdecryptionerror to error.py * Change error class name

…t#2612) * feat: add docs about docs * fix: improve looks * fix: make link work * fix: this looks better * Improved markdown, updated link * Less justifying Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

* Fix incomplete type annotations for CallbackContext Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

* Feat: Custom pytest marker Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

* Make basepersistence methods abstractmethod Signed-off-by: starry69 <starry369126@outlook.com> Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

)

…am-bot#2619, python-telegram-bot#2636)

…m-bot#2634) Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

python-telegram-bot#2657)

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: poolitzer <25934244+Poolitzer@users.noreply.github.com>

Poolitzer

You have one failing test here and it actually seems related to your changes. You wanna give it a shot at fixing? I can't recreate it myself sadly, using windows + py3.7, maybe someone else has a plan.

Bibo-Joshi

Thanks for your PR! I left a number of comments an questions :)
Apart from those:

Please double check that you added versioning directives everywhere where needed.
Just to clarify: Is there now any parameter that accepts Path objects in addition to what it accepted before? if so, please make sure that the tests cover both cases

harshil21

round 2 of reviews

Bibo-Joshi

Thanks for the new updates and sorry for making your merge-life harder unintentionally 😬
I think we're pretty much down to nitpicking details :)

…le.py, added a parametrized test_filepath_argument_types in test_persistence.py, and added test_download in test_request.py

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Bibo-Joshi

If tests run and @harshil21 approves as well, we can merge :)

eldbud · 2021-10-04T21:03:56Z

@Bibo-Joshi can you please role back your push to this branch? i can't push my changes, and some of yours i think break the test.

edit: reverted.

…eldbud/python-telegram-bot into pathlib-weherever-possible-2665

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

This reverts commit 96af7a6.

github-actions

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Bibo-Joshi · 2021-10-05T05:38:14Z

The failures where unrelated. I've reverted the reversion 😉

eldbud · 2021-10-05T07:03:52Z

The failures where unrelated. I've reverted the reversion 😉

did you make sure the test passes? this is how i initially wrote it and it failed.
when updating user data, the data is saved in FILENAME_user_data. so _user_data needs to be appended to the end of the original filename. without it, the is_file assetion fails.

Does this not happen to you?

Bibo-Joshi · 2021-10-05T07:25:25Z

@eldbud I removed single_file=False, so we don't need the _user_data extension 😉 The one currently failing test is unrelated

harshil21

good now!

Bibo-Joshi · 2021-10-05T17:51:09Z

Thank you for this contribution @eldbud ! Nice work :)

Bibo-Joshi and others added 23 commits September 15, 2021 17:09

Temporarily enable tests for the v14 branch

331c4f5

Move and Rename TelegramDecryptionError to telegram.error.PassportDec…

9dc30cf

…ryptionError (python-telegram-bot#2621) * move telegramdecryptionerror to error.py * Change error class name

Improve Type Hinting for CallbackContext (python-telegram-bot#2587)

3a19383

* Fix incomplete type annotations for CallbackContext Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

Add Custom pytest Marker to Ease Development (python-telegram-bot#2628)

414a18c

* Feat: Custom pytest marker Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

Make BasePersistence Methods Abstract (python-telegram-bot#2624)

8edb49d

* Make basepersistence methods abstractmethod Signed-off-by: starry69 <starry369126@outlook.com> Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

Refactor Initialization of Persistence Classes (python-telegram-bot#2604

cce9c18

)

Remove __dict__ from __slots__ and drop Python 3.6 (python-telegr…

dc0207a

…am-bot#2619, python-telegram-bot#2636)

Remove day_is_strict argument of JobQueue.run_monthly (python-telegra…

4af252f

…m-bot#2634) Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>

Drop Non-CallbackContext API (python-telegram-bot#2617)

b6e4b54

Fix Signatures and Improve test_official (python-telegram-bot#2643)

4359812

Remove Deprecated Functionality (python-telegram-bot#2644)

dbdd35e

Add User Friendly Type Check For Init Of {Inline, Reply}KeyboardMarkup (

a7c7c82

python-telegram-bot#2657)

Refine Dispatcher.dispatch_error (python-telegram-bot#2660)

8ac65fc

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Warnings Overhaul (python-telegram-bot#2662)

66f0604

Clear Up Import Policy (python-telegram-bot#2671)

4f21c06

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Make InlineQuery.answer Raise ValueError (python-telegram-bot#2675)

5542a46

merged from v14

1027e49

looks done

ec0665f

added self to AUTHORS.rst

f98883a

Doc Fixes (python-telegram-bot#2597)

2cf9311

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: poolitzer <25934244+Poolitzer@users.noreply.github.com>

Merge branch 'v14' into pathlib-weherever-possible-2665

bf0919c

final better utilisations of the Path module and some docstring update

eac94bd

Poolitzer linked an issue Oct 2, 2021 that may be closed by this pull request

Use pathlib weherever possible #2665

Closed

Poolitzer requested changes Oct 2, 2021

View reviewed changes

Comment thread telegram/ext/picklepersistence.py Outdated

Comment thread telegram/ext/picklepersistence.py Outdated

Bibo-Joshi requested changes Oct 2, 2021

View reviewed changes

eldbud added 2 commits October 3, 2021 02:29

attended to review notes

38c6641

fixed calls of PicklePersistence.__init__() with keyworded arg

d5fe778

Bibo-Joshi reviewed Oct 3, 2021

View reviewed changes

Comment thread telegram/files/file.py Outdated

harshil21 reviewed Oct 4, 2021

View reviewed changes

Comment thread telegram/dice.py Outdated

Comment thread telegram/ext/dispatcher.py Outdated

Comment thread telegram/ext/picklepersistence.py Outdated

Comment thread telegram/ext/picklepersistence.py Outdated

Comment thread telegram/files/file.py Outdated

Bibo-Joshi requested changes Oct 4, 2021

View reviewed changes

Comment thread telegram/ext/picklepersistence.py Outdated

Comment thread tests/test_persistence.py

Comment thread tests/test_request.py Outdated

Comment thread telegram/ext/dispatcher.py Outdated

Comment thread telegram/ext/picklepersistence.py Outdated

added parametrization for tests that deal with custom_path in test_fi…

654ea00

…le.py, added a parametrized test_filepath_argument_types in test_persistence.py, and added test_download in test_request.py

github-actions Bot reviewed Oct 4, 2021

View reviewed changes

bringing codecov back up

db9b6b1

github-actions Bot reviewed Oct 4, 2021

View reviewed changes

Bibo-Joshi reviewed Oct 4, 2021

View reviewed changes

Comment thread telegram/ext/picklepersistence.py Outdated

Comment thread telegram/ext/picklepersistence.py Outdated

Comment thread tests/test_persistence.py Outdated

some final details

70403ed

github-actions Bot reviewed Oct 4, 2021

View reviewed changes

Bibo-Joshi approved these changes Oct 4, 2021

View reviewed changes

attended to review notes

fa42e22

eldbud added 2 commits October 5, 2021 00:11

Merge branch 'pathlib-weherever-possible-2665' of https://github.com/…

ecc8248

…eldbud/python-telegram-bot into pathlib-weherever-possible-2665

brought back filepath.with_name(filepath.name etc)

96af7a6

github-actions Bot reviewed Oct 4, 2021

View reviewed changes

Revert "brought back filepath.with_name(filepath.name etc)"

5e10bd1

This reverts commit 96af7a6.

github-actions Bot reviewed Oct 5, 2021

View reviewed changes

eldbud requested review from Poolitzer and harshil21 October 5, 2021 07:53

harshil21 approved these changes Oct 5, 2021

View reviewed changes

Bibo-Joshi merged commit 6965ae9 into python-telegram-bot:v14 Oct 5, 2021

eldbud deleted the pathlib-weherever-possible-2665 branch October 5, 2021 18:25

github-actions Bot locked and limited conversation to collaborators Oct 7, 2021

harshil21 added the hacktoberfest-accepted other: hacktoberfest-accepted label Oct 30, 2021

Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024

Uh oh!

Conversation

eldbud commented Oct 2, 2021

Uh oh!

Poolitzer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Uh oh!

eldbud commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Bibo-Joshi commented Oct 5, 2021

Uh oh!

eldbud commented Oct 5, 2021

Uh oh!

Bibo-Joshi commented Oct 5, 2021

Uh oh!

harshil21 left a comment

Choose a reason for hiding this comment

Uh oh!

eldbud commented Oct 4, 2021 •

edited

Loading