Conversation
TimedOut exception is an expected an normal event. To reduce noise and make things more "fluent" we now: - Make sure that we don't sleep after the timeout but rather retry immediately. - Log debug instead of error level. Fixes #802
Eldinnie
reviewed
Feb 15, 2018
Eldinnie
left a comment
Member
There was a problem hiding this comment.
Generally it looks good. But I'm wondering. This will probably work fine for a shortly interrupted connection, but won't this hog memory when timedout is fired often?
| cur_interval = 0.5 + e.retry_after | ||
| except TimedOut as toe: | ||
| self.logger.debug('Timed out getting Updates: %s', toe) | ||
| # If getUpdates() failed due to timeout, we should retry asap. |
Fix comment per Eldinnie's request
Member
Author
|
@Eldinnie
|
Member
|
Good, merge after #1006 |
Member
Author
|
@Eldinnie Why after? |
Member
|
@tsnoam not really needed maybe, but that will make CI pass. And I prefer t if master passes CI |
Closed
This was referenced Mar 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimedOut exception is an expected an normal event. To reduce noise and
make things more "fluent" we now:
immediately.
Fixes #802