gh-156459: Fix cleanup on error in compiler_set_qualname - #156462
Merged
Conversation
carljm
approved these changes
Aug 28, 2026
…e-156459.Z8Zqik.rst Co-authored-by: Carl Meyer <carl@oddbird.net>
JelleZijlstra
approved these changes
Aug 29, 2026
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-156574 is a backport of this pull request to the 3.15 branch. |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
|
GH-156575 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the operation to _PyCompile_SetQualname and call it after _PyCompile_EnterScope returns (with cleanup if it fails).
Resolves #156459.
This was discovered through code inspection, not via a runtime bug. There is no reliable way to write a test for this as failures would be memory errors and the like.