Skip to content

gh-131492: gh-131461: handle exceptions in GzipFile constructor while owning resources #131462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 20 commits into from
Mar 20, 2025
+68 −52
Merged

gh-131492: gh-131461: handle exceptions in GzipFile constructor while owning resources #131462

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8abf17d
gh-131461: fix ResourceWarning when writing a unwritable gzipfile
graingert Mar 19, 2025
1193e6c
Merge branch 'main' into fix-resource-warning-in-gzipfile-ctor
graingert Mar 19, 2025
04f17ee
remove redundant self.fileobj = None
graingert Mar 19, 2025
99d4a47
Update Lib/gzip.py
graingert Mar 19, 2025
59ed512
Update Lib/gzip.py
graingert Mar 19, 2025
2ac99bd
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 19, 2025
0a9c81b
remember to raise
graingert Mar 19, 2025
cef776c
Update Misc/NEWS.d/next/Library/2025-03-19-14-36-54.gh-issue-131461.u…
graingert Mar 19, 2025
49f5a19
Update Lib/gzip.py
graingert Mar 19, 2025
d627689
Update Lib/gzip.py
graingert Mar 19, 2025
c9cdbf1
assert no resource warning on tarfile failing to write on open
graingert Mar 19, 2025
2217713
refactor gzip closing
graingert Mar 19, 2025
97ca4d3
Update Lib/gzip.py
graingert Mar 19, 2025
c9661e1
Update Lib/gzip.py
graingert Mar 19, 2025
8e54c5b
Update Lib/test/test_tarfile.py
graingert Mar 19, 2025
15a3058
fix resource warning in GzipFile if anything in the ctor fails such a…
graingert Mar 19, 2025
8351549
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 20, 2025
7de109e
Merge branch 'main' into fix-resource-warning-in-gzipfile-ctor
graingert Mar 20, 2025
052937f
Update Misc/NEWS.d/next/Library/2025-03-20-08-32-49.gh-issue-131492.s…
graingert Mar 20, 2025
643a00d
Update Misc/NEWS.d/next/Library/2025-03-20-08-32-49.gh-issue-131492.s…
graingert Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/gzip.py
  • Loading branch information
@graingert
graingert authored Mar 19, 2025
commit 49f5a19ee89f061f97bbdb37a087244eed992301
1 change: 1 addition & 0 deletions Lib/gzip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ def __init__(self, filename=None, mode=None,
finally:
self.fileobj = None
Comment thread
graingert marked this conversation as resolved.
Outdated
raise
Comment thread
graingert marked this conversation as resolved.

@property
def mtime(self):
"""Last modification time read from stream, or None"""
Expand Down