Handle cross-device file move - #4640
Merged
Merged
Conversation
ruslandoga
marked this pull request as ready for review
September 30, 2024 10:28
|
1 similar comment
|
macobo
approved these changes
Sep 30, 2024
This was referenced Sep 30, 2024
aerosol
reviewed
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
File.rename!with a customPlausible.File.mv!functions that triesFile.rename!first and falls back toFile.cp!andFile.rmin case of EXDEV error:Closes #4638
Since EE uses S3 instead of local disk for exports/imports, this PR only affects CE.